chore(round)!: Change Round.IgnoredPlayers to use Player#760
chore(round)!: Change Round.IgnoredPlayers to use Player#760louis1706 merged 4 commits intoExMod-Team:devfrom
Round.IgnoredPlayers to use Player#760Conversation
|
The only thing I'm curious is to why IgnoredPlayers has only a size of 20, I didn't changed since there might be a reason to it |
size of a List it's only a pregenerate memory you can add more than 20 player in it it's just than the list will not have the memory already available for it |
Someone-193
left a comment
Someone-193
left a comment
There was a problem hiding this comment.
good PR, wrong target branch though @louis1706, dont forget that when you merge this to Exiled 10
|
@Someone-193 changed the target branch, forgot abt changing it when i created the pr sorry |
|
Please keep it as targetting Dev Branch |
Someone-193
left a comment
Someone-193
left a comment
There was a problem hiding this comment.
I think there's some of your warhead PR stuff in here lol
|
@Someone-193 oh yeah it did 😞 mb |
|
when I made the pr I tried to make sure there were no changes from the other branch but looks like I fucked up |
3 participants
Description
Describe the changes
What is the current behavior? (You can also link to an open issue here)
Round.IgnoredPlayersusingPlayerWhat is the new behavior? (if this is a feature change)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Round.IgnoredPlayershashset will be usingPlayerinstead ofReferenceHubOther information:
Wanted to do this cause it's simple copy and paste in the IL side
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other